-
Notifications
You must be signed in to change notification settings - Fork 181
Upgrade from 7.17 guide #3398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from 7.17 guide #3398
Conversation
|
placeholder added: #3409 dropped |
|
Hi @eedugon thanks for the PR! This is very helpful! I have one thing to ask for your insights: cc @Gunnerva as this is under your area. |
|
@kunisen , thanks a lot for sharing that interesting issue. We'll definitely add that information, but it needs to be added in the standard docs also, as that information is relevant in general for upgrades on ECH using the API (i.e when using terraform as you said). I'll find the best way to address it. Then in this cc: @shainaraskas , probably the issue that @kunisen has addressed deserves a separate issue, WDYT? |
|
@eedugon yes it can be handled separately |
shainaraskas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're on the right track. I mostly made cosmetic edits.
for ingest, I think we need some more targeted links. otherwise I think we're striking the right balance
we can always build on this if people are reporting specific difficulties.
|
There are two places in the guide that say:
How about the following to be clear that they need to click on every in between version's migration guide 😄
|
On this note, it seems like there can be a client "outage" for Java clients between the time the Elasticsearch version is upgraded to the next major version and when they upgrade their client libraries to match. The linked doc states that the java client will only work with same or higher minor version without breaking. So from a planning point of view, they may need to have 2 client applications running different library versions in parallel or need the ability to quickly hot swap client library versions as soon as the server version is upgraded. |
|
In the https://www.elastic.co/docs/deploy-manage/upgrade/prepare-to-upgrade#run-the-upgrade-assistant which is cross-referenced from this guide, it says:
The archived link takes you to a page that only talks about indices created in versions 5 or 6. So what about indices created in 7.x? Are they not supported by the mark-as-read-only/archive feature? Can we confirm with the devs and update the docs accordingly? Thx! |
|
Thanks @ppf2 !! I'll keep track of all your comments, let me share something to begin with:
I'm 99% sure that's a docs bug caused during the docs migration, and we didn't adapt the doc to the 9.x reality (it says indices on v5 and v6 because that content was created in 8.x, where 7.x indices didn't need archive). Indices in 7.x are definitely valid for
For the clients issue I really hope and think that all our clients in 7.17 are compatible with 8.19 generally speaking, of course they could be affected by breaking changes but in general they should work. And also the REST API Compatibility mode should be an option for users to consider. I had already updated the docs on this regard giving better visibility to this (I agree the docs could make the impression of an outage). We have this doc and worklow created since 8.0 docs, and I really hope all client libraries are aligned on that regard. My plan to address this is:
|
shainaraskas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm almost done with my review but going to a meeting. can't say enough good things about what I have read so far - this guide is really complex but super clean and easy to follow, and just packed with great info. will make people feel confident in the upgrade process 🚀
going to provisionally approve because nothing so far is blocking, just in case you need to ship timewise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should also surface this doc on the parent page
here: https://www.elastic.co/docs/deploy-manage/upgrade/deployment-or-cluster
and here: https://www.elastic.co/docs/deploy-manage/upgrade
we should also consider surfacing 7.x upgrade paths here (or at least linking to the source of truth): https://www.elastic.co/docs/deploy-manage/upgrade#upgrade-paths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
|
||
| It's highly recommended to start this upgrade from the latest 8.19.x patch release to ensure that you’re using the most recent version of the **Upgrade Assistant**. | ||
|
|
||
| :::::{important} note for Enterprise Search users |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good, but be careful about assuming that the design of this note will always remain the same. honestly I'm cool with shipping this, but this component could be redesigned and then your sentence will be broken. something to keep in mind as you use these components in future :) would go with plain admonition blocks if you want custom title text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, converted to admonition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple more comments (done reviewing). looks great.
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
This PR adds a new ad-hoc document to guide users to upgrade from 7.17.x to 9.x, which requires two major upgrades plus upgrading all ingest components and clients between the upgrades. It supports all deployment types, covers orchestrator upgrades, etc. This new document builds upon and links to the existing upgrade documentation. Its purpose is to bring together all relevant upgrade steps and considerations into a single, end-to-end guide that walks through what would normally be an exercise each user performs independently when planning a full stack upgrade, considering the specifics of this upgrade path. It is not intended to introduce new upgrade procedures or instructions, as these should already be accurately documented in the existing upgrade guides. Closes elastic/docs-content-internal#387 --------- Co-authored-by: shainaraskas <[email protected]>
This PR adds a new ad-hoc document to guide users to upgrade from 7.17.x to 9.x, which requires two major upgrades plus upgrading all ingest components and clients between the upgrades. It supports all deployment types, covers orchestrator upgrades, etc. This new document builds upon and links to the existing upgrade documentation. Its purpose is to bring together all relevant upgrade steps and considerations into a single, end-to-end guide that walks through what would normally be an exercise each user performs independently when planning a full stack upgrade, considering the specifics of this upgrade path. It is not intended to introduce new upgrade procedures or instructions, as these should already be accurately documented in the existing upgrade guides. Closes elastic/docs-content-internal#387 --------- Co-authored-by: shainaraskas <[email protected]>
This PR adds a new ad-hoc document to guide users to upgrade from 7.17.x to 9.x, which requires two major upgrades plus upgrading all ingest components and clients between the upgrades.
It supports all deployment types, covers orchestrator upgrades, etc.
This new document builds upon and links to the existing upgrade documentation.
Its purpose is to bring together all relevant upgrade steps and considerations into a single, end-to-end guide that walks through what would normally be an exercise each user performs independently when planning a full stack upgrade, considering the specifics of this upgrade path.
It is not intended to introduce new upgrade procedures or instructions, as these should already be accurately documented in the existing upgrade guides.
Closes https://github.com/elastic/docs-content-internal/issues/387
cc: @ppf2 / @shainaraskas