Skip to content

Conversation

shainaraskas
Copy link
Collaborator

@shainaraskas shainaraskas commented Feb 5, 2025

Users and roles PR #1. Part of https://github.com/elastic/docs-projects/issues/347

Does the following (click for preview :))

cleans up raw files I used up and fixes links I broke, fixes some html stuff that was causing tests to fail

working on ECE/cluster in a separate PR to make this easier to review/merge

@shainaraskas shainaraskas changed the title Users and roles Users and roles: Overviews, cloud org, project custom roles Feb 16, 2025
eedugon
eedugon previously approved these changes Feb 17, 2025
Copy link
Contributor

@eedugon eedugon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing, I love how the overviews look and how everything flows!
Just shared some minor comments, and approving anyway.

Copy link
Contributor

@eedugon eedugon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
I only saw something a bit weird, at the end of the cluster-or-deployment-auth/user-roles.md file:

For more information, see Document-level attribute-based access control with X-Pack 6.1.

I would remove X-Pack 6.1 from there.
I wouldn't even link such an old blog, but if we keep it at least I would remove the X-Pack mention, as it's not applicable anymore.

Anyway awesome work! Let's continue moving forward!!!

@shainaraskas shainaraskas merged commit 4e87fce into main Feb 18, 2025
4 checks passed
@shainaraskas shainaraskas deleted the users-roles branch February 18, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants