Skip to content

Conversation

naemono
Copy link
Contributor

@naemono naemono commented Oct 15, 2025

Question

  • Do we want to also document how to rotate the Kibana encryption keys?

Related: elastic/cloud-on-k8s#8839

@naemono naemono requested a review from a team as a code owner October 15, 2025 14:48
::::

:::{note}
Previous documentation suggested deleting all secrets with the label `eck.k8s.elastic.co/credentials=true`, which included the Kibana secret that contained encryption keys. Deletion of the Kibana config secret is not recommended.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love the wording here. Suggestions welcome.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest not referring to the previous docs when making corrections - if people think they saw something here previously, they can look in the git history. instead, we can tell them what to avoid and why. something like:

Suggested change
Previous documentation suggested deleting all secrets with the label `eck.k8s.elastic.co/credentials=true`, which included the Kibana secret that contained encryption keys. Deletion of the Kibana config secret is not recommended.
When deleting secrets so they can be regenerated, make sure to exclude {{kib}} secrets by specifying `type!=kibana`. {{kib}} secrets contain encryption keys, which should not be deleted.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates ECK documentation to improve the credential rotation process by preventing accidental deletion of Kibana encryption keys. The change refines the kubectl command to exclude Kibana secrets and adds a warning note about previous documentation.

  • Modified kubectl command to exclude Kibana secrets when rotating credentials
  • Added explanatory note about why Kibana config secrets should not be deleted

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with a suggestion

::::

:::{note}
Previous documentation suggested deleting all secrets with the label `eck.k8s.elastic.co/credentials=true`, which included the Kibana secret that contained encryption keys. Deletion of the Kibana config secret is not recommended.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest not referring to the previous docs when making corrections - if people think they saw something here previously, they can look in the git history. instead, we can tell them what to avoid and why. something like:

Suggested change
Previous documentation suggested deleting all secrets with the label `eck.k8s.elastic.co/credentials=true`, which included the Kibana secret that contained encryption keys. Deletion of the Kibana config secret is not recommended.
When deleting secrets so they can be regenerated, make sure to exclude {{kib}} secrets by specifying `type!=kibana`. {{kib}} secrets contain encryption keys, which should not be deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants