- 
                Notifications
    
You must be signed in to change notification settings  - Fork 172
 
Add note on S3 replication #3507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note on S3 replication #3507
Conversation
It's not clear from these docs that S3 object replication doesn't work reliably. This commit spells this out and explains why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some minor suggestions and link fix.
| Unfortunately this replication is not compatible with {{es}} snapshots. | ||
| The objects that {{es}} writes to the repository refer to other objects which already exist in the repository, and {{es}} only deletes an object from the repository after it becomes unreferenced by all other objects. | ||
| AWS S3 replication will apply operations to the replica repository in a different order from the order in which {{es}} applies them to the primary repository, and this may leave the replica repository in an invalid state, with objects referring to other objects that do not exist. | ||
| To replicate a repository's contents elsewhere you must follow the [repository backup](snapshot-and-restore/self-managed.md#snapshots-repository-backup) process. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| To replicate a repository's contents elsewhere you must follow the [repository backup](snapshot-and-restore/self-managed.md#snapshots-repository-backup) process. | |
| To replicate a repository's contents elsewhere, follow the [repository backup](/deploy-manage/tools/snapshot-and-restore/self-managed.md#snapshots-repository-backup) process. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous should fix the link that is making the build to fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ thanks
| AWS S3 supports [replication of objects](https://docs.aws.amazon.com/AmazonS3/latest/userguide/replication.html), both within a single region and across regions. | ||
| Unfortunately this replication is not compatible with {{es}} snapshots. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original proposal is going to place the 5 lines in the same paragraph, i'm going to propose to divide the content in 3 different paragraphs.
| AWS S3 supports [replication of objects](https://docs.aws.amazon.com/AmazonS3/latest/userguide/replication.html), both within a single region and across regions. | |
| Unfortunately this replication is not compatible with {{es}} snapshots. | |
| AWS S3 supports [replication of objects](https://docs.aws.amazon.com/AmazonS3/latest/userguide/replication.html), both within a single region and across regions. However, this replication mechanism is not compatible with {{es}} snapshots. | |
| AWS S3 supports [replication of objects](https://docs.aws.amazon.com/AmazonS3/latest/userguide/replication.html), both within a single region and across regions. | ||
| Unfortunately this replication is not compatible with {{es}} snapshots. | ||
| The objects that {{es}} writes to the repository refer to other objects which already exist in the repository, and {{es}} only deletes an object from the repository after it becomes unreferenced by all other objects. | ||
| AWS S3 replication will apply operations to the replica repository in a different order from the order in which {{es}} applies them to the primary repository, and this may leave the replica repository in an invalid state, with objects referring to other objects that do not exist. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| AWS S3 replication will apply operations to the replica repository in a different order from the order in which {{es}} applies them to the primary repository, and this may leave the replica repository in an invalid state, with objects referring to other objects that do not exist. | |
| Because AWS S3 replication can apply operations to the replica repository in a different order than {{es}} applies them to the primary repository, the replica repository can become invalid, with objects referring to others that do not exist. | |
| 
           removing myself as a reviewer since @eedugon looked at this. @DaveCTurner no need to request one of us directly (my colleagues are usually a little faster with reviews than I am 😅)  | 
    
| 
           Thanks Edu, good call on splitting up into multiple paragraphs. I expanded the middle paragraph a little and made some of the changes you suggested.  | 
    
          🔍 Preview links for changed docs | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just added a minor suggestion to improve the flow and rhythm of the biggest paragraph, for your consideration.
We also need to check why the CI job is failing. I'll check internally with docs engineers.
Co-authored-by: Edu González de la Herrán <[email protected]>
It's not clear from these docs that S3 object replication doesn't work reliably. This commit spells this out and explains why. Co-authored-by: Edu González de la Herrán <[email protected]>
It's not clear from these docs that S3 object replication doesn't work reliably. This commit spells this out and explains why. Co-authored-by: Edu González de la Herrán <[email protected]>
It's not clear from these docs that S3 object replication doesn't work
reliably. This commit spells this out and explains why.