-
Notifications
You must be signed in to change notification settings - Fork 165
Add OOB alerts and alert rule template as asset type #3537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔍 Preview links for changed docs |
|
cc:/ @nimarezainia @MichelLosier @nchaulet @kpollich Here's a draft. Please let me know what you think, and we can iterate. |
|
Thank you @karenzone I think we need to document the alert name, condition it is looking for and a blurb description for it (which could just be copy+past from the issue). Regarding the alerts as integration assets: if we have an example to show that would be great. I know that this content is very much dependent on what the package owner adds to their package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @karenzone! LGMT 🚀 Just left some small suggestions for your consideration.
|
@vishaangelova, thank you for the review! I'm merging this now and putting up a follow-up PR to add alerts as they firm up. I'll address your comments then. |
Related:
#2760
This PR:
To Do: