Skip to content

Conversation

@emilioalvap
Copy link
Contributor

Summary

Adjust synthetics docs to support elastic-agent base image for non-browser monitors.

Relates to https://github.com/elastic/synthetics-dev/issues/402.

@emilioalvap emilioalvap changed the title [Synthetics] Adjust private location docs to support base elastic-agent image [Synthetics] Adjust private location docs to support base elastic-agent Nov 5, 2025
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Copy link
Contributor

@lucabelluccini lucabelluccini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some suggestions as I think being more explicit as possible is the best.
Also I would recommend, for the 'default' path, to show the complete option.

There are less chances someone will have to redo the download/tutorial because they blindly copy pasted the steps without reading the warnings and then they discover they would like to run a browser monitor.

@emilioalvap
Copy link
Contributor Author

Thanks for the suggestions @lucabelluccini, I still need to add a reference to alternative elastic-agent (basic) install methods, which we will also be supporting from now on. I'll update the default tab options to show the complete variant first as you suggested

Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few suggestions. Let me know if you have any questions or comments.

@emilioalvap emilioalvap enabled auto-merge (squash) November 12, 2025 23:21
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple minor suggestions below to make the way we refer to synthetic browser monitors in the Fleet docs more consistent with how we refer to them in the Observability docs.

Co-authored-by: Colleen McGinnis <[email protected]>
@github-actions
Copy link

github-actions bot commented Nov 21, 2025

Vale Linting Results

Summary: 1 suggestion found

💡 Suggestions (1)
File Line Rule Message
solutions/observability/synthetics/monitor-resources-on-private-networks.md 61 Elastic.Acronyms 'ICMP' has no definition.

@emilioalvap
Copy link
Contributor Author

Thanks @colleenmcginnis and @mdbirnstiehl for the suggestions! Please review again and let me know if this is ready for merging.

@emilioalvap
Copy link
Contributor Author

@colleenmcginnis @mdbirnstiehl Kind reminder to review the committed changes and provide an approval if everything is Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants