-
Notifications
You must be signed in to change notification settings - Fork 181
[Synthetics] Adjust private location docs to support base elastic-agent #3831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
lucabelluccini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made some suggestions as I think being more explicit as possible is the best.
Also I would recommend, for the 'default' path, to show the complete option.
There are less chances someone will have to redo the download/tutorial because they blindly copy pasted the steps without reading the warnings and then they discover they would like to run a browser monitor.
solutions/observability/synthetics/monitor-resources-on-private-networks.md
Outdated
Show resolved
Hide resolved
solutions/observability/synthetics/monitor-resources-on-private-networks.md
Outdated
Show resolved
Hide resolved
solutions/observability/synthetics/migrate-from-elastic-synthetics-integration.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Luca Belluccini <[email protected]>
…e-networks.md Co-authored-by: Luca Belluccini <[email protected]>
Co-authored-by: Luca Belluccini <[email protected]>
Co-authored-by: Luca Belluccini <[email protected]>
|
Thanks for the suggestions @lucabelluccini, I still need to add a reference to alternative elastic-agent (basic) install methods, which we will also be supporting from now on. I'll update the default tab options to show the complete variant first as you suggested |
mdbirnstiehl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few suggestions. Let me know if you have any questions or comments.
solutions/observability/synthetics/migrate-from-elastic-synthetics-integration.md
Outdated
Show resolved
Hide resolved
solutions/observability/synthetics/migrate-from-elastic-synthetics-integration.md
Outdated
Show resolved
Hide resolved
solutions/observability/synthetics/monitor-resources-on-private-networks.md
Outdated
Show resolved
Hide resolved
solutions/observability/synthetics/migrate-from-elastic-synthetics-integration.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Mike Birnstiehl <[email protected]>
colleenmcginnis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple minor suggestions below to make the way we refer to synthetic browser monitors in the Fleet docs more consistent with how we refer to them in the Observability docs.
Co-authored-by: Colleen McGinnis <[email protected]>
Vale Linting ResultsSummary: 1 suggestion found 💡 Suggestions (1)
|
|
Thanks @colleenmcginnis and @mdbirnstiehl for the suggestions! Please review again and let me know if this is ready for merging. |
|
@colleenmcginnis @mdbirnstiehl Kind reminder to review the committed changes and provide an approval if everything is Ok |
Summary
Adjust synthetics docs to support
elastic-agentbase image for non-browser monitors.Relates to https://github.com/elastic/synthetics-dev/issues/402.