[ON week] review and fix Vale checks corrected by Cursor #3878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Preview links for changed docs |
Collaborator
shainaraskas
left a comment
shainaraskas
left a comment
There was a problem hiding this comment.
couple spot checks
|
|
||
| * Create, read, update, and delete documents. | ||
| * Perform everything from simple keyword searches to complex analytical aggregations. | ||
| * Create, read, update, and remove documents. |
Collaborator
There was a problem hiding this comment.
We need to keep delete in cases like this because it reflects CRUD ops
| * Create, read, update, and delete documents. | ||
| * Perform everything from simple keyword searches to complex analytical aggregations. | ||
| * Create, read, update, and remove documents. | ||
| * Perform everything from efficient keyword searches to complex analytical aggregations. |
Collaborator
There was a problem hiding this comment.
simple is accurate here (reflects actual search complexity, rather than a judgement on how complex it is for a user to execute on)
| * The APIs provide direct access to the core capabilities of Elasticsearch and Kibana. If you can do it in the UI, you can automate it with the API. | ||
| * Elastic provides and supports official [clients](/reference/elasticsearch-clients/index.md) for popular languages like Java, Go, .NET, PHP, Python, Ruby, and JavaScript. These clients simplify interacting with the API, handling requests, and processing responses. | ||
| * The APIs are secured using role-based access control (RBAC). You can create API keys or use bearer tokens with fine-grained permissions to ensure your interactions are safe. | ||
| * Role-based access control (RBAC) secures the APIs. You can create API keys or use bearer tokens with fine-grained permissions to ensure your interactions are safe. |
Collaborator
There was a problem hiding this comment.
the grammar of the original sentence is more clear imo - this is a good case for passive voice
| This approach is ideal for shipping data, logs, metrics, and traces. By building an integration, you contribute to the ever-growing ecosystem that both you and the community can benefit from. | ||
|
|
||
| * Integrations are built on a consistent framework, providing users with a turnkey experience, including dashboards, visualizations, and alerts. | ||
| * We build integrations on a consistent framework, providing users with a turnkey experience, including dashboards, visualizations, and alerts. |
Collaborator
There was a problem hiding this comment.
"we" is not right here. it indicates that integrations provide consistency by leveraging a framework, but integrations aren't always built by "us" - that's why we have an extensibility guide for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.