-
Notifications
You must be signed in to change notification settings - Fork 181
Fix serverless applicability in setting up data streams docs #4083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yetanothertw
wants to merge
5
commits into
main
Choose a base branch
from
3384-applies-to
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3384 and updates the page so that it can be used for both Stack and Serverless scopes.
Vale Linting ResultsSummary: 1 warning, 1 suggestion found
|
| File | Line | Rule | Message |
|---|---|---|---|
| manage-data/data-store/data-streams/set-up-data-stream.md | 314 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'. |
💡 Suggestions (1)
| File | Line | Rule | Message |
|---|---|---|---|
| manage-data/data-store/data-streams/set-up-data-stream.md | 314 | Elastic.FutureTense | 'will require' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
🔍 Preview links for changed docs |
…er to scan by adding tabs
kilfoyle
reviewed
Nov 28, 2025
kilfoyle
reviewed
Nov 28, 2025
kilfoyle
reviewed
Nov 28, 2025
kilfoyle
reviewed
Nov 28, 2025
kilfoyle
reviewed
Nov 28, 2025
kilfoyle
reviewed
Nov 28, 2025
kilfoyle
reviewed
Nov 28, 2025
kilfoyle
approved these changes
Nov 28, 2025
Contributor
kilfoyle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🌲
I love having these tabs with the UI steps and I think it's much clearer now that the first step applies only to non-Serverless users. Looks great!
My suggestions are all just super minor things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
Team:Admin
Issues owned by the Admin Docs Team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3384 and updates the page so that it can be used for both Stack and Serverless scopes.
Summary
I've added a bit more context around the step to create an ILM policy included in this tutorial, and why it is not required in a Serverless context.
I've also added tabs to the sections that list both Kibana steps and steps using the API. Each section now also links to the corresponding Serverless API doc page.
Generative AI disclosure