-
Notifications
You must be signed in to change notification settings - Fork 162
[D&M] Drafts maintenance content #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ent into szabosteve/maintenance
…ent into szabosteve/maintenance
…ent into szabosteve/maintenance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks very very good!
most of my comments are nitpicks and little typo things I saw. overall:
- Please add
applies_to
to all pages (the new syntax is out now) - From overview pages, link down to the pages you're referring to
- Duplicate content about adding nodes can be removed from the "start/stop es" topic
- Noted where some small glue content and clarification about what procedures apply to what deployment types would be helpful (and hopefully quick)
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've provided some suggestions re: changes to the "applies_to" tags. most of my reasoning is based on extrapolating other info in the page (e.g. the install methods on start/stop es are just self-managed install methods). let me know if you disagree with any of the labeling.
sry for the second round of comments - it's looking vv great, just want to make sure we have the page scopes right 🎯
deploy-manage/maintenance/add-and-remove-elasticsearch-nodes.md
Outdated
Show resolved
Hide resolved
deploy-manage/maintenance/start-stop-services/restart-cloud-hosted-deployment.md
Outdated
Show resolved
Hide resolved
deploy-manage/maintenance/start-stop-services/start-stop-elasticsearch.md
Show resolved
Hide resolved
Co-authored-by: shainaraskas <[email protected]>
…icsearch.md Co-authored-by: shainaraskas <[email protected]>
…ent into szabosteve/maintenance
…tart-rolling-restart-procedures.md Co-authored-by: shainaraskas <[email protected]>
Overview
Related to https://github.com/elastic/docs-projects/issues/353
This PR:
starting-elasticsearch.md
andstopping-elasticsearch.md
) and adding an intro to the page