-
Notifications
You must be signed in to change notification settings - Fork 156
[solutions] Replace AsciiDoc API links #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @colleenmcginnis, I'm wondering why no Security files are included in this PR? We don't have too many instances of linking to our API docs in Security, but I know we have some (one example here). |
|
||
`chunking_settings` | ||
: (Optional, object) Chunking configuration object. Refer to [Configuring chunking](https://www.elastic.co/guide/en/elasticsearch/reference/current/inference-apis.html#infer-chunking-config) to learn more about chunking. | ||
: (Optional, object) Chunking configuration object. Refer to [Configuring chunking](https://www.elastic.co/docs/api/doc/elasticsearch/group/endpoint-inference) to learn more about chunking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately this link doesn't make sense anymore because that information is not in the new reference yet
This holds for all of these ones in the inference-api
directory.
cc @szabosteve @charlotte-hoblik
we might just have to remove these links entirely for the moment until that chunking information is restored somewhere centrally? LMKWYT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://elastic.slack.com/archives/C059JCWTPMX/p1739268759792579 (platform docs channel)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@colleenmcginnis feel free to ignore this and we'll create a TODO to handle it next week :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Some links needed to be more targeted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more, sorry my internet is choppy so had to chunk this review 🙈
solutions/search/full-text/search-relevance/consistent-scoring.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Liam Thompson <[email protected]>
This example should be covered in #435. This PR is only covering files currently in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙇
Replace AsciiDoc API links that should redirect to the new API docs. For more details, refer to https://github.com/elastic/docs-projects/issues/414#issuecomment-2654939177.