-
Notifications
You must be signed in to change notification settings - Fork 195
Updates Automatic Migration to add QRadar support #4673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Vale Linting ResultsSummary: 1 warning, 2 suggestions found
|
| File | Line | Rule | Message |
|---|---|---|---|
| solutions/security/get-started/automatic-migration.md | 67 | Elastic.DontUse | Don't use 'just'. |
💡 Suggestions (2)
| File | Line | Rule | Message |
|---|---|---|---|
| solutions/security/get-started/automatic-migration.md | 81 | Elastic.FutureTense | 'will have' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| solutions/security/get-started/automatic-migration.md | 192 | Elastic.FutureTense | 'will generate' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
The Vale linter checks documentation changes against the Elastic Docs style guide.
To use Vale locally or report issues, refer to Elastic style guide for Vale.
🔍 Preview links for changed docs |
Charelzard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my one comment below and please also incorporate the warning for BB/building blocks.
mdbirnstiehl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of suggestions for your consideration. Otherwise, LGTM!
[Merge on release day for 9.3]
Fixes #638 by documenting that QRadar rules are now supported by Automatic Migration.
Charles, are there any missing limitations or requirements for QRadar rules that are supported? E.g. certain versions, certain kinds of rules, anything like that?
Generative AI disclosure