Skip to content

Conversation

@theletterf
Copy link
Contributor

@theletterf theletterf commented Jan 21, 2026

Summary

Contributes to https://github.com/elastic/docs-content-internal/issues/654

Generative AI disclosure

  1. Did you use a generative AI (GenAI) tool to assist in creating this contribution?
  • Yes
  • No
  1. If you answered "Yes" to the previous question, please specify the tool(s) and model(s) used (e.g., Google Gemini, OpenAI ChatGPT-4, etc.).

Tool(s) and model(s) used: Claude Opus 4.5 in Cursor

@theletterf theletterf requested review from a team as code owners January 21, 2026 13:49
@theletterf theletterf requested review from Mpdreamz and v1v January 21, 2026 13:49
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

✅ Vale Linting Results

No issues found on modified lines!


The Vale linter checks documentation changes against the Elastic Docs style guide.

To use Vale locally or report issues, refer to Elastic style guide for Vale.

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
theletterf and others added 2 commits January 21, 2026 15:00
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these be moved to .github/scripts ?

Since the root folders are all docs.

@Mpdreamz
Copy link
Member

Ahh there is prior art: https://github.com/elastic/docs-content/tree/main/scripts

Still would be nice to have these in .github/scripts.

@theletterf
Copy link
Contributor Author

@Mpdreamz Want to do that in a follow-up PR if that's OK. Could you approve so we merge this one?

@theletterf theletterf requested a review from Mpdreamz January 21, 2026 16:53
@theletterf theletterf enabled auto-merge (squash) January 21, 2026 17:02
@theletterf theletterf disabled auto-merge January 21, 2026 17:02
@theletterf theletterf requested a review from v1v January 21, 2026 17:14
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just added a few suggestions

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
@theletterf theletterf enabled auto-merge (squash) January 21, 2026 17:25
@theletterf theletterf merged commit 64852ce into main Jan 21, 2026
7 of 8 checks passed
@theletterf theletterf deleted the add-sheet2csv-automation branch January 21, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants