-
Notifications
You must be signed in to change notification settings - Fork 156
Users roles 2: just users #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Edu González de la Herrán <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good.
I just added a few more comments.
deploy-manage/users-roles/cluster-or-deployment-auth/built-in-users.md
Outdated
Show resolved
Hide resolved
deploy-manage/users-roles/cluster-or-deployment-auth/built-in-users.md
Outdated
Show resolved
Hide resolved
deploy-manage/users-roles/cluster-or-deployment-auth/manage-elastic-user-cloud.md
Show resolved
Hide resolved
deploy-manage/users-roles/cluster-or-deployment-auth/built-in-eck.md
Outdated
Show resolved
Hide resolved
deploy-manage/users-roles/cluster-or-deployment-auth/built-in-overview.md
Outdated
Show resolved
Hide resolved
deploy-manage/users-roles/cluster-or-deployment-auth/built-in-users.md
Outdated
Show resolved
Hide resolved
deploy-manage/users-roles/cluster-or-deployment-auth/built-in-users.md
Outdated
Show resolved
Hide resolved
…users.md Co-authored-by: Edu González de la Herrán <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggested a few small changes, i think we are getting there!
deploy-manage/users-roles/cluster-or-deployment-auth/built-in-users.md
Outdated
Show resolved
Hide resolved
deploy-manage/users-roles/cluster-or-deployment-auth/built-in-sm.md
Outdated
Show resolved
Hide resolved
deploy-manage/users-roles/cluster-or-deployment-auth/orchestrator-managed-users-overview.md
Outdated
Show resolved
Hide resolved
deploy-manage/users-roles/cluster-or-deployment-auth/orchestrator-managed-users-overview.md
Outdated
Show resolved
Hide resolved
…sm.md Co-authored-by: Edu González de la Herrán <[email protected]>
…tor-managed-users-overview.md Co-authored-by: Edu González de la Herrán <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, awesome work!
please take a look at the
users
section. roles TODONote re: external auth provider tutorials
The external auth provider tutorials generally diverge in three ways between deployment types:
I want to create "core" docs for all of these concepts that cross deployment types. For now, I've done the following:
touched the config steps as little as possible - editing these adds a lot of weight
linked to the existing "core" doc for secure settings - need to find a balance re: detail of these sections. hard to do when the secure settings doc isn't written
used a note to link to the various bundles procedures
I'm going to fix these inconsistencies as a followup - right now I'm mostly concerned with getting the content merged together