Skip to content

Conversation

eedugon
Copy link
Contributor

@eedugon eedugon commented Feb 25, 2025

Second PR related with https://github.com/elastic/docs-projects/issues/339

Main pages to review:

NOTE about installation docs: there's a lot of duplicated content and some architectural issues that I want to address (not sure if here or in a different PR). At the moment I haven't changed anything on that regard.

@shainaraskas shainaraskas self-requested a review February 25, 2025 14:44
@shainaraskas
Copy link
Collaborator

added myself as a reviewer so this would pop up in my notifications and I could remember to look at it

Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my internet is glitching so I am submitting a batch of comments

Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more comments coming!

deploy-manage/deploy/cloud-enterprise/log-into-cloud-ui didn't get its ece applies_to tag

Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! mostly added comments around some wayfinding polish you could do and the relationship between the install docs. nothing major

@eedugon eedugon requested a review from shainaraskas March 5, 2025 21:22
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@eedugon eedugon merged commit 57ea966 into main Mar 6, 2025
4 checks passed
@eedugon eedugon deleted the ece_install_configure branch March 6, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants