Skip to content

Conversation

kosabogi
Copy link
Contributor

@kosabogi kosabogi commented Mar 4, 2025

This PR adds the missing mapped URLs listed in this sheet.

@kosabogi kosabogi requested a review from eedugon March 4, 2025 11:12
Copy link
Contributor

@eedugon eedugon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't leave empty lines inside the YAML entry block of the pages.
I'd suggest to remove them.

Then I think we have a missing URL in the add-plugins-extensions doc, as it has an heroku URL but it's missing the ECH url.

@@ -1,4 +1,7 @@
---
mapped_urls:
- https://www.elastic.co/guide/en/cloud-heroku/current/ech-adding-plugins.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do we have the URL https://www.elastic.co/guide/en/cloud/current/ec-adding-plugins.html mapped?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That URL is mapped to Reference - Elasticsearch plugins - Plugin management page, according to the IA inventory.

Copy link
Contributor

@eedugon eedugon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosabogi kosabogi merged commit 755561b into main Mar 4, 2025
4 checks passed
@kosabogi kosabogi deleted the mapped_urls branch March 4, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants