Skip to content

Conversation

alaudazzi
Copy link
Contributor

@alaudazzi alaudazzi commented Mar 5, 2025

@alaudazzi alaudazzi requested a review from lcawl March 5, 2025 20:04
@alaudazzi alaudazzi self-assigned this Mar 5, 2025
@alaudazzi alaudazzi changed the title [Observability metrics reference] Add the serverless to the frontmatter [Observability metrics reference] Add serverless to the frontmatter Mar 5, 2025
@lcawl
Copy link
Contributor

lcawl commented Mar 5, 2025

I wonder if this file shouldn't just be removed since it duplicates https://github.com/elastic/docs-content/tree/main/reference/data-analysis/observability/index.md?

Then just update the frontmatter in index.md to make it clear it replaces two pages:

---
mapped_pages:
  - https://www.elastic.co/guide/en/observability/current/metrics-reference.html
  - https://www.elastic.co/guide/en/serverless/current/observability-metrics-reference.html
 applies_to:
  stack: all
  serverless: all
---

Actually that applies_to is probably unnecessary, since it's asserting what should generally be the default (i.e. the page applies to everything).

@alaudazzi alaudazzi changed the title [Observability metrics reference] Add serverless to the frontmatter [Observability metrics reference] Remove duplicated file Mar 11, 2025
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My assumption is we'll also do the same for the child pages (which currently have "-serverless" in the URL), but this page LGTM

@alaudazzi alaudazzi merged commit 9c145cc into main Mar 11, 2025
4 checks passed
@alaudazzi alaudazzi deleted the update-frontmatter branch March 11, 2025 14:58
alaudazzi added a commit that referenced this pull request Mar 17, 2025
This PR removes "-serverless" from the file name.

Follow-up on #669
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants