-
Notifications
You must be signed in to change notification settings - Fork 159
Updates instructions for self-managed connectors #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Built elastic-dot-co-docs-preview-docs successfully!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kosabogi this is perfect! 👌
Just couple minor structural suggestions to improve the doc generally:
- Add steps for the action sub-headings, I suggested Steps 1 and 2 but couldn't comment on the untouched sections below
- Step 3: Enter data source details in UI
- Step 4: Connect to an index
- Swap the order of the Docker and source instructions to lead with Docker
serverless/pages/ingest-your-data-ingest-data-through-integrations-connector-client.mdx
Outdated
Show resolved
Hide resolved
serverless/pages/ingest-your-data-ingest-data-through-integrations-connector-client.mdx
Outdated
Show resolved
Hide resolved
serverless/pages/ingest-your-data-ingest-data-through-integrations-connector-client.mdx
Show resolved
Hide resolved
…ions-connector-client.mdx Co-authored-by: Liam Thompson <[email protected]>
…ions-connector-client.mdx Co-authored-by: Liam Thompson <[email protected]>
Thank you for your review @leemthompo ! I adjusted all of your suggestions in my newest commit. Here are some details related the topics mentioned in the issue and my changes/findings related to them: ------------------------------- THE ISSUE AND THE RELATED CHANGES IN DETAILS ------------------------------- The values should match the literals in the UI and in the config.yml file: Should there be a link to the connectors report here or is clone command enough (I ask because the link to the example config.yml that is in the repo is linked...btw, I opened and copied it and then realized it was actually in the same repo...maybe say its actual name so I don't assume I'm getting it from somewhere else and I can easily find it in my cloned local directory) --- DONE, I decided to delete the link for the file on Github, and tell users that they can find the config.yml.example in the repo they've just cloned. Further up. The API key instructions are out of date. The elasticsearch.host value is also on the new connector page. --- DONE The editing of the config.yml is the same in both docker and python cases. The example was much more helpful in the docker section. We should probably reconcile them. --- DONE Also are there special permissions required because my API key on the service returns 401 from the elasticsearch host. --- I couldn't find anything related to this, because I didn't receive error message related my API key. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overview
This PR updates the Connector clients page in the Serverless documentation.
Related issue:
[Serverless]: Connector Run from source procedure clarifications #68
Preveiw
Connector clients