Skip to content

Conversation

wajihaparvez
Copy link
Contributor

@wajihaparvez wajihaparvez commented Mar 14, 2025

This PR adds the Third-party dependencies section to the Install Kibana page. I also updated the section on the Deploy an Elasticsearch cluster page for consistency (@shainaraskas hope that's okay!)

Closes: #212706
Rel: #214667, #214668

@wajihaparvez wajihaparvez self-assigned this Mar 14, 2025
@wajihaparvez wajihaparvez changed the title [Docs] Add link to dependencies page [Docs] Add link to dependencies page - v3 Mar 14, 2025
@wajihaparvez wajihaparvez removed the request for review from geekpete March 14, 2025 21:58
@wajihaparvez
Copy link
Contributor Author

@geekpete FYI, this PR just adds the same changes to the new docs

Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is ok for now. consider alternatively putting the content into a snippet and including it on both pages, or moving it up a page because it applies to the whole stack


## Third-party dependencies

Refer to [{{stack}} third-party dependencies](https://artifacts.elastic.co/reports/dependencies/dependencies-current.html) for a list of the external dependencies you can leverage.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the person "leveraging" the dependencies? wouldn't the dependencies just be needed for functioning of es?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep let's stick to the original wording

Suggested change
Refer to [{{stack}} third-party dependencies](https://artifacts.elastic.co/reports/dependencies/dependencies-current.html) for a list of the external dependencies you can leverage.
Refer to [{{stack}} third-party dependencies](https://artifacts.elastic.co/reports/dependencies/dependencies-current.html) for the complete list of dependencies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're both right, the original wording works. I was overthinking it. Updated wording and turned the text into a snippet to include on both pages. Thanks!

Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's just use unambiguous wording ("you can leverage" makes them sound optional)

## Third-party dependencies [dependencies-versions]

See [Elastic Stack third-party dependencies](https://artifacts.elastic.co/reports/dependencies/dependencies-current.html) for the complete list of dependencies for {{es}}.
Refer to [{{stack}} third-party dependencies](https://artifacts.elastic.co/reports/dependencies/dependencies-current.html) for a list of the external dependencies you can leverage.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Refer to [{{stack}} third-party dependencies](https://artifacts.elastic.co/reports/dependencies/dependencies-current.html) for a list of the external dependencies you can leverage.
Refer to [{{stack}} third-party dependencies](https://artifacts.elastic.co/reports/dependencies/dependencies-current.html) for the complete list of dependencies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Updated!

wajihaparvez added a commit to elastic/kibana that referenced this pull request Mar 17, 2025
## Summary

This PR adds a page to the 9.0 Kibana docs linking to the list of
third-party dependencies.

Closes: [#212706](#212706)
Rel: #214667,
[#797](elastic/docs-content#797)

---------

Co-authored-by: florent-leborgne <[email protected]>
wajihaparvez added a commit to elastic/kibana that referenced this pull request Mar 17, 2025
## Summary

This PR adds a page to the 8.x Kibana docs linking to the list of
third-party dependencies.

Closes: #212706
Rel: #214668,
[#797](elastic/docs-content#797)

---------

Co-authored-by: florent-leborgne <[email protected]>
@wajihaparvez wajihaparvez merged commit b70bcd0 into elastic:main Mar 17, 2025
4 checks passed
@wajihaparvez wajihaparvez deleted the 212706/kibana-dependencies-md branch March 17, 2025 18:12
wajihaparvez added a commit to wajihaparvez/kibana that referenced this pull request Mar 18, 2025
## Summary

This PR adds a page to the 8.x Kibana docs linking to the list of
third-party dependencies.

Closes: elastic#212706
Rel: elastic#214668,
[elastic#797](elastic/docs-content#797)

---------

Co-authored-by: florent-leborgne <[email protected]>
wajihaparvez added a commit to wajihaparvez/kibana that referenced this pull request Mar 18, 2025
## Summary

This PR adds a page to the 8.x Kibana docs linking to the list of
third-party dependencies.

Closes: elastic#212706
Rel: elastic#214668,
[elastic#797](elastic/docs-content#797)

---------

Co-authored-by: florent-leborgne <[email protected]>
wajihaparvez added a commit to wajihaparvez/kibana that referenced this pull request Mar 18, 2025
## Summary

This PR adds a page to the 8.x Kibana docs linking to the list of
third-party dependencies.

Closes: elastic#212706
Rel: elastic#214668,
[elastic#797](elastic/docs-content#797)

---------

Co-authored-by: florent-leborgne <[email protected]>
wajihaparvez added a commit to wajihaparvez/kibana that referenced this pull request Mar 18, 2025
## Summary

This PR adds a page to the 8.x Kibana docs linking to the list of
third-party dependencies.

Closes: elastic#212706
Rel: elastic#214668,
[elastic#797](elastic/docs-content#797)

---------

Co-authored-by: florent-leborgne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOCS] Link to single source of truth Kibana dependencies list page in docs per stack version

3 participants