-
Notifications
You must be signed in to change notification settings - Fork 157
[Docs] Add link to dependencies page - v3 #797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Add link to dependencies page - v3 #797
Conversation
@geekpete FYI, this PR just adds the same changes to the new docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is ok for now. consider alternatively putting the content into a snippet and including it on both pages, or moving it up a page because it applies to the whole stack
|
||
## Third-party dependencies | ||
|
||
Refer to [{{stack}} third-party dependencies](https://artifacts.elastic.co/reports/dependencies/dependencies-current.html) for a list of the external dependencies you can leverage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is the person "leveraging" the dependencies? wouldn't the dependencies just be needed for functioning of es?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep let's stick to the original wording
Refer to [{{stack}} third-party dependencies](https://artifacts.elastic.co/reports/dependencies/dependencies-current.html) for a list of the external dependencies you can leverage. | |
Refer to [{{stack}} third-party dependencies](https://artifacts.elastic.co/reports/dependencies/dependencies-current.html) for the complete list of dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're both right, the original wording works. I was overthinking it. Updated wording and turned the text into a snippet to include on both pages. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's just use unambiguous wording ("you can leverage" makes them sound optional)
## Third-party dependencies [dependencies-versions] | ||
|
||
See [Elastic Stack third-party dependencies](https://artifacts.elastic.co/reports/dependencies/dependencies-current.html) for the complete list of dependencies for {{es}}. | ||
Refer to [{{stack}} third-party dependencies](https://artifacts.elastic.co/reports/dependencies/dependencies-current.html) for a list of the external dependencies you can leverage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refer to [{{stack}} third-party dependencies](https://artifacts.elastic.co/reports/dependencies/dependencies-current.html) for a list of the external dependencies you can leverage. | |
Refer to [{{stack}} third-party dependencies](https://artifacts.elastic.co/reports/dependencies/dependencies-current.html) for the complete list of dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Updated!
## Summary This PR adds a page to the 9.0 Kibana docs linking to the list of third-party dependencies. Closes: [#212706](#212706) Rel: #214667, [#797](elastic/docs-content#797) --------- Co-authored-by: florent-leborgne <[email protected]>
## Summary This PR adds a page to the 8.x Kibana docs linking to the list of third-party dependencies. Closes: #212706 Rel: #214668, [#797](elastic/docs-content#797) --------- Co-authored-by: florent-leborgne <[email protected]>
## Summary This PR adds a page to the 8.x Kibana docs linking to the list of third-party dependencies. Closes: elastic#212706 Rel: elastic#214668, [elastic#797](elastic/docs-content#797) --------- Co-authored-by: florent-leborgne <[email protected]>
## Summary This PR adds a page to the 8.x Kibana docs linking to the list of third-party dependencies. Closes: elastic#212706 Rel: elastic#214668, [elastic#797](elastic/docs-content#797) --------- Co-authored-by: florent-leborgne <[email protected]>
## Summary This PR adds a page to the 8.x Kibana docs linking to the list of third-party dependencies. Closes: elastic#212706 Rel: elastic#214668, [elastic#797](elastic/docs-content#797) --------- Co-authored-by: florent-leborgne <[email protected]>
## Summary This PR adds a page to the 8.x Kibana docs linking to the list of third-party dependencies. Closes: elastic#212706 Rel: elastic#214668, [elastic#797](elastic/docs-content#797) --------- Co-authored-by: florent-leborgne <[email protected]>
This PR adds the Third-party dependencies section to the Install Kibana page. I also updated the section on the Deploy an Elasticsearch cluster page for consistency (@shainaraskas hope that's okay!)
Closes: #212706
Rel: #214667, #214668