Skip to content

Conversation

jmikell821
Copy link
Contributor

@jmikell821 jmikell821 commented Mar 18, 2025

Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small suggestions, otherwise LGTM!

Copy link
Contributor

@eedugon eedugon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ECK doc looks very nice and clean!
I have added a couple of comments for the ECE deployment upgrade doc.

I've also suggested to change the titles, as upgrade on ECE or upgrade on ECK lacks clarity. It's better (IMO) upgrade deployment on ECE.

If you want a shorter title on the left menu consider setting upgrade on ECE and upgrade on ECK as navigation_titles. That i'd say would be fine, but the real title of the doc should clearly specify what the doc is about, and with ugprade on ECK we lack context about what the doc is about (upgrading what exactly?).


Once you've successfully upgraded on {{ece}}, do the following:

* [Upgrade Elastic APM](../../../solutions/observability/apps/upgrade.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this upgrade Elastic APM about? If APM and Fleet are part of the deployment and managed by ECE they should be automatically upgraded. If that document covers the case of an external APM server connected to the deployment (rare case) then I would specify it. I don't completely understand it, so probably that item needs extra background for the users too.

@jmikell821 jmikell821 merged commit 92482af into main Mar 18, 2025
4 checks passed
@jmikell821 jmikell821 deleted the upgrade-updates branch March 18, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants