-
Notifications
You must be signed in to change notification settings - Fork 157
[Upgrade 9.0] Adds ECE/ECK upgrade topics #812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small suggestions, otherwise LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ECK doc looks very nice and clean!
I have added a couple of comments for the ECE deployment upgrade doc.
I've also suggested to change the titles, as upgrade on ECE
or upgrade on ECK
lacks clarity. It's better (IMO) upgrade deployment on ECE
.
If you want a shorter title on the left menu consider setting upgrade on ECE
and upgrade on ECK
as navigation_titles
. That i'd say would be fine, but the real title of the doc should clearly specify what the doc is about, and with ugprade on ECK
we lack context about what the doc is about (upgrading what exactly?).
|
||
Once you've successfully upgraded on {{ece}}, do the following: | ||
|
||
* [Upgrade Elastic APM](../../../solutions/observability/apps/upgrade.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this upgrade Elastic APM
about? If APM and Fleet are part of the deployment and managed by ECE they should be automatically upgraded. If that document covers the case of an external APM server connected to the deployment (rare case) then I would specify it. I don't completely understand it, so probably that item needs extra background for the users too.
Contributes to https://github.com/elastic/docs-projects/issues/247 and https://github.com/elastic/docs-projects/issues/355.
Previews: