Skip to content

Conversation

shainaraskas
Copy link
Collaborator

@shainaraskas shainaraskas commented Mar 19, 2025

Finishes and lightly restructures the following sections:

^^ This logging section was a mess. the Kibana stuff was especially tricky, and needed to be broken up along generic (log level) and advanced (everything else) lines.

I split it the way I split it because cloud hosted doesn't accept logging.logger or logging.appenders. There's a chance that you could use these in ECK/ECE (proof) so I left it open to those three deployment types. we might need to refine if it causes problems.

@shainaraskas shainaraskas changed the title orchestrator stuff Monitoring: orchestrators, kib task manager, logging config Mar 19, 2025
@shainaraskas shainaraskas changed the title Monitoring: orchestrators, kib task manager, logging config [D+M] Monitoring: orchestrators, kib task manager, logging config Mar 19, 2025
@shainaraskas shainaraskas marked this pull request as ready for review March 19, 2025 21:56
@shainaraskas shainaraskas requested a review from eedugon March 19, 2025 21:57
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this and the other ts fix 🙏

Copy link
Contributor

@eedugon eedugon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments.
The logging section feels really good now, great work simplifying the mess

@shainaraskas shainaraskas merged commit 8151cb0 into main Mar 21, 2025
4 checks passed
@shainaraskas shainaraskas deleted the monitoring-pt3 branch March 21, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants