-
Notifications
You must be signed in to change notification settings - Fork 163
Clarify ECK support scope for ingress controllers #908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kunisen : instead of adding the title in the note, try a plain admonition, and let me know your thoughts: I'm also rewording a bit the statement, for your consideration too: :::{admonition} Support scope for Ingress Controllers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've suggested a small change in the text and a plain admonition with the title instead of a note
.
deploy-manage/deploy/cloud-on-k8s/managing-deployments-using-helm-chart.md
Outdated
Show resolved
Hide resolved
deploy-manage/deploy/cloud-on-k8s/requests-routing-to-elasticsearch-nodes.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Edu González de la Herrán <[email protected]>
Co-authored-by: Edu González de la Herrán <[email protected]>
…elm-chart.md Co-authored-by: Edu González de la Herrán <[email protected]>
Co-authored-by: Edu González de la Herrán <[email protected]>
…earch-nodes.md Co-authored-by: Edu González de la Herrán <[email protected]>
Thanks @eedugon |
it looks nicer now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot!
Background
In an internal ticket (stl-1548) and also an internal slack channel, @jeanfabrice, @pebrc and I discussed about support scope of ingress controllers.
We came up with the plan to clarify this in public doc as below:
Docs need updated
Text to add
docs-content pages to edit
Sample view
:: Without link
:: With link
Clicking the link example ingress configuration recipes will redirect page to http://localhost:3000/deploy-manage/deploy/cloud-on-k8s/recipes