Skip to content

Conversation

jmikell821
Copy link
Contributor

@jmikell821 jmikell821 commented Mar 25, 2025

@jmikell821 jmikell821 requested a review from Gunnerva March 25, 2025 20:09
@jmikell821 jmikell821 requested review from drempapis and javanna March 26, 2025 02:17
Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two minor comments, rest looks good to me.

Copy link

@drempapis drempapis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmikell821 jmikell821 merged commit c65e2f5 into main Mar 26, 2025
4 checks passed
@jmikell821 jmikell821 deleted the upgrade-es-indices branch March 26, 2025 16:09

In the future, we plan on streamlining the upgrade process going forward, making it easier to take legacy indices along when going to future major {{es}} versions.
1. Take a snapshot of the indices in the old cluster.
2. Delete any indices created before 8.0.0.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get confused about which ES version we are now covering. If it's about upgrading from 5.x or 6.x, the instructions don't change in 9.0 compared to before? I think that this 8.0.0 should actually still be 7.0.0. Does that make sense?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That depends probably if you need to write to the index or not. 7.0 indices won't block the upgrade if in read-only mode so maybe we could expand this to describe this or link to relevant docs elsewhere?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that yes, but I think the version that was incremented from 7.0 to 8.0 per-se is wrong?

2. Delete any indices created before 8.0.0.
3. Upgrade the cluster without the old indices, then [restore](https://www.elastic.co/docs/api/doc/elasticsearch/operation/operation-snapshot-restore) the legacy indices from the snapshot or [mount](https://www.elastic.co/docs/api/doc/elasticsearch/operation/operation-searchable-snapshots-mount) them using searchable snapshots.

% In the future, we plan on streamlining the upgrade process going forward, making it easier to take legacy indices along when going to future major {{es}} versions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This last note no longer makes sense, isn't that what we have done with 9.0, meaning that you can bring along indices that were previously archived in 8.x (from 5.x or 6.x), as well as mark 7.x indices read-only and take them with you ? @cbuescher does that make sense to you?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"take legacy indices along when going to future major {{es}} versions"

I think this statement is ambiguous, like e.g. I could mean being able to write to legacy indices as well. We know that's not what it means or will probably ever mean but I think the intention when this was added was to say we will keep improving this. I'm not sure we need to keep this around, but I also don't think we've reached with with v9 yet, e.g. you cannot simply keep version 5/6 indices through an upgrade without remounting a snapshot as far as I know. Or am I wrong here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you cannot simply keep version 5/6 indices through an upgrade without remounting a snapshot as far as I know

yes you can!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then lets scratch that last note here, it that what you suggest?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that's what I'd suggest, if you agree :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants