Skip to content

Conversation

mdbirnstiehl
Copy link
Contributor

@mdbirnstiehl mdbirnstiehl commented Mar 25, 2025

This PR closes Issue 4820

Here's the preview of the main upgrade page linking to the broken changes.

@mdbirnstiehl mdbirnstiehl requested a review from simitt March 25, 2025 22:19
@mdbirnstiehl mdbirnstiehl marked this pull request as ready for review March 25, 2025 22:19
Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a stab at this. I have a few comments:

  • The file names that you are changing all have upgrade-xxxx-to-8` in their names, but this is about upgrading to 9. File names should probably be changed accordingly?
  • For improved usability, I suggest to also link to the Breaking Changes in all these guides, in addition to linking to the release notes. WDYT?

@mdbirnstiehl
Copy link
Contributor Author

Thanks for taking a stab at this. I have a few comments:

  • The file names that you are changing all have upgrade-xxxx-to-8` in their names, but this is about upgrading to 9. File names should probably be changed accordingly?
  • For improved usability, I suggest to also link to the Breaking Changes in all these guides, in addition to linking to the release notes. WDYT?

Makes sense! I'll make the updates today.

@mdbirnstiehl mdbirnstiehl requested a review from simitt March 26, 2025 21:16
Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@mdbirnstiehl mdbirnstiehl requested a review from a team March 27, 2025 18:53
@mdbirnstiehl mdbirnstiehl requested a review from jmikell821 March 28, 2025 14:09
@mdbirnstiehl mdbirnstiehl merged commit 800eddd into elastic:main Apr 2, 2025
4 checks passed
@mdbirnstiehl mdbirnstiehl deleted the apm-9-upgrade branch April 2, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants