-
Notifications
You must be signed in to change notification settings - Fork 159
Security comms #941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security comms #941
Conversation
deploy-manage/security/_snippets/cluster-communication-network.md
Outdated
Show resolved
Hide resolved
Co-authored-by: shainaraskas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments, mostly regarding the security features by deployment type stuff
Co-authored-by: shainaraskas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/941/deploy-manage/security/enabling-cipher-suites-for-stronger-encryption and https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/941/deploy-manage/security/supported-ssltls-versions-by-jdk-version is missing applies
info.
on the cipher suites page, it would be good to specify whether the cipher suites are enabled by default in other deployment types as well. there is also a floating backtick on the page that needs to be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK comments are done now :)
all of them are either me being picky or small accuracy questions that should be easy to knock out. will checkmark this in case you're feeling excited to merge it but you should try to clean up the little style weirdness and make sure every page has applies tags.
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
I forgot to apply a commit in #941 Minor changes cc: @shainaraskas --------- Co-authored-by: shainaraskas <[email protected]>
This PR updates the certificates and security-setup information. Part of https://github.com/elastic/docs-projects/issues/346#issue-2788754652
self-setup.md
file.Main pages to review:
Still pending (not sure if doing that in this PR or in another one).