Skip to content

Conversation

@eedugon
Copy link
Contributor

@eedugon eedugon commented Jan 30, 2025

This needs review as I have some concerns due to:

  • We have already master pointing to 9.0.0.
  • There's a comment on ECS about keeping it in 8.17.

Comments added in the code.

@eedugon eedugon requested a review from a team as a code owner January 30, 2025 09:37
@github-actions
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@eedugon eedugon requested review from bmorelli25 and lcawl January 30, 2025 09:41
@eedugon
Copy link
Contributor Author

eedugon commented Feb 11, 2025

@lcawl , @bmorelli25 , I'd need an approval on this PR soon.
Based on @karenzone comment it looks this is blocking other docs repositories to create things for 8.18, like https://github.com/elastic/logstash-docs/actions/runs/13249296075.

The only remaining issue on this PR is if the prev-major-last: value on master.asciidoc needs to be bumped to 8.18 or if we leave it in 8.17. I've updated it to 8.18.

@bmorelli25
Copy link
Member

run docs-build rebuild

bmorelli25
bmorelli25 previously approved these changes Feb 11, 2025
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eedugon
Copy link
Contributor Author

eedugon commented Feb 12, 2025

run docs-build rebuild

@eedugon
Copy link
Contributor Author

eedugon commented Feb 12, 2025

@elasticmachine run docs-build rebuild

@eedugon eedugon merged commit c5d6435 into elastic:master Feb 12, 2025
3 checks passed
@eedugon eedugon deleted the add-8.18 branch February 12, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants