Skip to content

Conversation

v1v
Copy link
Member

@v1v v1v commented Sep 17, 2024

What does this PR do?

Use the GitHub app to generate the required ephemeral tokens with the least permissive principle.

Why

  • Finer-grained tokens with Service Machine accounts are required to rotate the secrets manually.
  • GitHub app to generate temporary tokens is the advanced approach to avoid the above
  • Document what the GH workflow requires to run in terms of access
  • GitHub Token with Permissions does not trigger GitHub builds

Implementation details

Use tibdex/github-app-token with the required permissions and the repository scope
Remove the permissions configuration in the GH workflow.
Configure git checkout with the ephemeral token
Configure the GH_TOKEN with the ephemeral token

@v1v v1v requested review from a team September 17, 2024 11:12
@v1v v1v self-assigned this Sep 17, 2024
@v1v
Copy link
Member Author

v1v commented Sep 24, 2024

@elastic/apm-agent-java , I plan to merge in the next day or so, do you have any questions/concerns?

@v1v v1v merged commit d0b2cfe into elastic:main Sep 25, 2024
8 checks passed
@v1v v1v deleted the feature/release-automation-1 branch September 25, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants