Skip to content

ci: fix semgrep reported run-shell-injection #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2025
Merged

ci: fix semgrep reported run-shell-injection #347

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8109bf6
ci: fix semgrep reported run-shell-injection
oakrizan Aug 6, 2025
73839c5
updated PR according to reviews
oakrizan Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/maven-goal/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,7 @@ runs:
java-version-file: .java-version
distribution: ${{ inputs.distribution }}
cache: 'maven'
- run: ${{ inputs.command }}
- run: "$COMMAND"
shell: ${{ inputs.shell }}
env:
COMMAND: ${{ inputs.command }}
8 changes: 6 additions & 2 deletions .github/workflows/pre-post-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,14 @@ jobs:
- name: Push the ${{ inputs.phase }} release branch
run: |
git add --all
git commit -m "${{ inputs.phase }} release: ecs-logging-java v${{ env.RELEASE_VERSION }}"
git commit -m "$PHASE release: ecs-logging-java v${{ env.RELEASE_VERSION }}"
git push origin ${{ env.BRANCH_NAME }}
env:
PHASE: ${{ inputs.phase }}

- name: Create the ${{ inputs.phase }} release PR
run: gh pr create --title="${{ inputs.pr_title }}" --base main --head ${{ env.BRANCH_NAME }} -b "${{ inputs.pr_body }}"
run: gh pr create --title="$PR_TITLE" --base main --head ${{ env.BRANCH_NAME }} -b "$PR_BODY"
env:
GH_TOKEN: ${{ steps.get_token.outputs.token }}
PR_TITLE: ${{ inputs.pr_title }}
PR_BODY: ${{ inputs.pr_body }}
8 changes: 5 additions & 3 deletions .github/workflows/validate-tag/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,13 @@ runs:
id: validate-tag
shell: 'bash'
run: |
if ! [ $(echo "${{ inputs.tag }}" | grep -P "(\d{1,2})\.(\d{1,2})\.(\d{1,2})") ]; then
if ! [ $(echo "$TAG" | grep -P "(\d{1,2})\.(\d{1,2})\.(\d{1,2})") ]; then
echo "Tag should be a SemVer format"
exit 1
fi
if [ $(git tag -l "${{ inputs.tag }}") ]; then
echo "The tag ${{ inputs.tag }} already exists"
if [ $(git tag -l "$TAG") ]; then
echo "The tag $TAG already exists"
exit 1
fi
env:
TAG: ${{ inputs.tag }}
Loading