chore(slack-lite): switch to pull_request_target so have access to repo secrets #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…po secrets No need for us to be running code from the PR itself, so this event is fine. Before this change, a workflow run for a PR from a *fork* would have 'Secret source: None' and hence not have access to the SLACK_BOT_TOKEN Also be clearer on the 'slack-lite' brand. Refs: elastic/apm-agent-nodejs#4501
david-luna
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need for us to be running code from the PR itself, so this event is fine.
Before this change, a workflow run for a PR from a fork would have
'Secret source: None' and hence not have access to the SLACK_BOT_TOKEN
Also be clearer on the 'slack-lite' brand.
Refs: elastic/apm-agent-nodejs#4501