Clarify url.query usage to specify full query string format#2488
Merged
kgeller merged 12 commits intoelastic:mainfrom Dec 16, 2025
Merged
Clarify url.query usage to specify full query string format#2488kgeller merged 12 commits intoelastic:mainfrom
kgeller merged 12 commits intoelastic:mainfrom
Conversation
This update removes ambiguity around the url.query field by explicitly stating that it should contain the full query string, including compound parameters. An example with multiple query parameters is added to reinforce this guidance. This helps prevent misinterpretation—such as splitting the query into an array of keywords—and promotes consistent, ECS-compliant implementations across ingestion pipelines and tools.
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
💚 CLA has been signed |
4d5c51e to
d76d6d8
Compare
Contributor
Author
|
run docs-build |
Contributor
|
we could also add a link to definition as we do in semantic conventions https://opentelemetry.io/docs/specs/semconv/registry/attributes/url/ |
|
Hi! We just realized that we haven't looked into this PR in a while. We're We're labeling this PR as Thank you for your contribution! |
🔍 Preview links for changed docs |
mjwolf
approved these changes
Dec 15, 2025
trisch-me
reviewed
Dec 16, 2025
kgeller
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update removes ambiguity around the url.query field by explicitly stating that it should contain the full query string, including compound parameters.
An example with multiple query parameters is added to reinforce this guidance. This helps prevent misinterpretation—such as splitting the query into an array of keywords—and promotes consistent, ECS-compliant implementations across ingestion pipelines and tools.
make test?makeand committed those changes?