Closed
Conversation
Rename the _types module to ecs_types. Modules with leading underscore are reserved for internal use, and in newer version of python there is an internal _types module which conflicts with the ecs _types. The ECS module is renamed to ecs_types, to remove the conflict with the internal type.
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
|
This PR could be closed after your commits being merged through my PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. What does this PR do?
Modules with leading underscore are reserved for internal use, and in newer version of python there is an internal _types module which conflicts with the ecs _types. The ECS module is renamed to ecs_types, to remove the conflict with the internal _types.
2. Which ECS fields are affected/introduced?
None
3. Why is this change necessary?
This fixed a build error when using Python 3.14.0+
4. Have you added/updated documentation?
N/A
5. Have you built ECS and committed any newly generated files?
YES
6. Have you run the ECS validation tests locally?
YES
7. Anything else for the reviewers?
Commit Message
Modules with leading underscore are reserved for internal use, and in newer version of python there is an internal _types module which conflicts with the ecs _types. The ECS module is renamed to ecs_types, to remove the conflict with the internal _types.