Skip to content

Conversation

colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented Aug 15, 2025

🧀 Pairs with elastic/elastic-agent#9440

Overview

Adds the ability to generate Markdown files for release notes, breaking changes, and deprecations in the new format used on https://www.elastic.co/docs/release-notes/fleet.

Approach

Updates the render command to accept --file_type set to either asciidoc or markdown.

Adds two new fields to the fragment template to be used when the kind is breaking-change, deprecation, or known-issue:

  • impact: User impact of the change (a few sentences).
  • action: Steps for mitigating the described user impact (a few sentences).

Updates the recommended configuration file name (from config to config.changelog.yaml) and format for individual repos (elastic-agent and fleet-server) in order to save the rendered files in the appropriate location so all versions can be compiled onto a page for each: release notes, breaking changes, and deprecations. See an example of this structure in elastic/elastic-agent#9440.

Open questions

  • Can we make impact and action required for breaking-change, deprecation, or known-issue fragments?
  • Should we continue to accept template instead of file_type?

@colleenmcginnis colleenmcginnis self-assigned this Aug 15, 2025
@colleenmcginnis colleenmcginnis changed the title [work in progress] Update release notes for the Markdown era Update release notes for the Markdown era Aug 20, 2025
@colleenmcginnis colleenmcginnis marked this pull request as ready for review August 20, 2025 19:42
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very familiar with the codebase, so my comments are fairly high-level.

Can we make impact and action required for breaking-change, deprecation, or known-issue fragments?

I understand breaking-change and deprecation usage.

Can you provide an example of known-issue? I'm probably just missing some context of how to use.

I'm not very familiar with where the best to spot to "enforce" this change. I think if we wanted to require impact and action, it would be in build (this is how we validate in PR checks).

Should we continue to accept template instead of file_type?

I don't have context about the usage of --template to answer. In my limited experience, I've never used that flag.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @colleenmcginnis

@colleenmcginnis
Copy link
Contributor Author

Thanks @ebeahan!

I'm not very familiar with the codebase, so my comments are fairly high-level.

Is there anyone else who should review?

Can you provide an example of known-issue? I'm probably just missing some context of how to use.

I initially included automation for adding content to the Markdown known issues page, but I ended up removing it since recently we've been adding known issues manually post-release (example, example, example, example). I'm not sure if we should try to automate those.

I don't have context about the usage of --template to answer. In my limited experience, I've never used that flag.

Prior to this PR, there was only one template available, asciidoc-embedded, which was the default value so there was no reason to use it in the past.

@ebeahan
Copy link
Member

ebeahan commented Aug 26, 2025

Is there anyone else who should review?

Let me reach out to my team and ask for some additional feedback.

@pierrehilbert
Copy link
Collaborator

Even if you are no more handling this project, maybe you can still take a look here @endorama?

@pierrehilbert
Copy link
Collaborator

From what I know, we are not automatically checking the fragment content but only if a fragment is available in the PR.
Updating the template as you did and communicating that change to the team is probably the best path for now.

Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@colleenmcginnis do create a new release once these changes are merged.

colleenmcginnis added a commit to elastic/docs-content that referenced this pull request Sep 11, 2025
…elease notes (#2818)

Related to elastic/docs-projects#488
elastic/elastic-agent-changelog-tool#213,
elastic/elastic-agent#9440,
elastic/fleet-server#5374

⚠️ **DO NOT MERGE BEFORE
elastic/docs-builder#1830 IS BOTH MERGED AND
INCLUDED IN A NEW RELEASE** ⚠️

Removes the combined Fleet Server and Elastic Agent release notes in
favor of separate release notes in the fleet-server and elastic-agent
repos. This enables the dev team to own the release notes process.
@colleenmcginnis colleenmcginnis merged commit 451fd80 into elastic:main Sep 11, 2025
7 checks passed
@colleenmcginnis colleenmcginnis deleted the markdown branch September 11, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants