feat: switch back to upstream pkcs8 lib #344
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elastic forker the library to fix modern go version support and bump the x/crypto dependency this has been fixed upstream so we should switch back to it update imports and run go mod tidy
kruskall
requested review from
andrzej-stencel and
khushijain21
and removed request for
a team
💚 Build Succeeded
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
elastic forked the library to fix modern go version support and bump the x/crypto dependency
this has been fixed upstream so we should switch back to it
update imports and run go mod tidy
Why is it important?
the elastic fork of pkcs8 is only used in elastic-agent-libs
we should drop it and archive the repo
Checklist
Author's Checklist
Related issues