mage: Improve error messages and resource handling #10446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes minor developer tooling improvements: - Improves the checksum mismatch error message for better diagnostics. - Fix spurious "error closing" logs when double-closing files explicitely and with `defer`
pchila
reviewed
Oct 9, 2025
|
|
||
| func closeOrLog(closer io.Closer, what string) { | ||
| err := closer.Close() | ||
| if err == nil || errors.Is(err, os.ErrClosed) { |
There was a problem hiding this comment.
This is a change in behavior: you are explicitly ignoring os.ErrClosed. Wouldn't it be better to figure out where we are closing the same io.Closer twice ?
There was a problem hiding this comment.
That can be done as well but I figured cleanliness is slightly preferred over having to set nil to the file pointers, at least for this part of the code. Other parts don't even log the Close errors.
💚 Build Succeeded
History
cc @orestisfl |
pierrehilbert
added
the
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit includes minor developer tooling improvements:
deferWhy is it important?
Checklist
./changelog/fragmentsusing the changelog tool