-
Notifications
You must be signed in to change notification settings - Fork 197
[fix] Replace deprecated SetupMetrics
with SetupMetricsOptions
#10468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[fix] Replace deprecated SetupMetrics
with SetupMetricsOptions
#10468
Conversation
SetupMetrics
with SetupMetricsOptions
This pull request does not have a backport label. Could you fix it @hayotbisonai? 🙏
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
This pull request is now in conflicts. Could you fix it? 🙏
|
* chore: remove otel diagnostics from manager * test * more testing and refactor * fix tests * refactor
* Fix troubleshooting message URL for versions after 9.x * Add changelog fragment * Change troubleshoot message to a const variable * Fix build issue created by the merge * Fix linter issue * Revert linter fix and add nolint comment
Name: agentName, | ||
Version: version.GetDefaultVersion(), | ||
Logger: logger, | ||
EphemeralID: ephemeralID, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try leaving out this field? We've done it in other places, e.g. https://github.com/elastic/beats/blob/fe58b38aafa2410ee59c1feeec64fbf5a180f09e/x-pack/libbeat/cmd/instance/receiver.go#L53-L59 or https://github.com/elastic/fleet-server/blob/589cd522193e485b8a3c3958a2b3032569b81a4e/internal/pkg/api/metrics.go#L77-L83
What does this PR do?
SetupMetrics
withSetupMetricsOptions
generateEphemeralID
that generates id for setting up metricsWhy is it important?
Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself