-
Notifications
You must be signed in to change notification settings - Fork 197
[8.19] (backport #10415) [edot][diagnostics] remove otel diagnostics from manager #10599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 8.19
Are you sure you want to change the base?
Conversation
* chore: remove otel diagnostics from manager * test * more testing and refactor * fix tests * refactor (cherry picked from commit 7afb200) # Conflicts: # internal/pkg/agent/application/actions/handlers/handler_action_diagnostics_test.go # internal/pkg/agent/application/actions/handlers/mock_server.go # internal/pkg/otel/manager/diagnostics.go # testing/integration/ess/diagnostics_test.go
Cherry-pick of 7afb200 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
This pull request is now in conflicts. Could you fix it? 🙏
|
What does this PR do?
This PR removes the manual hooks i.e.
FileBeatRegistryTarGz
,GetBeatJsonMetricsDiagnostics
andGetBeatInputMetricsDiagnostics
functions.These diagnostics are already collected by EDOT Diagnostics Extension.
Why is it important?
This PR fixes a bug where you get prompted every-time to replace files when extracting diagnostics when using EDOT.
Checklist
./changelog/fragments
using the changelog toolRelated issues
Screenshot
This is an automatic backport of pull request #10415 done by [Mergify](https://mergify.com).