Skip to content

Conversation

@v1v
Copy link
Member

@v1v v1v commented Jun 5, 2025

What does this PR do?

  • Run on Saturdays, a few hours after VM images are produced.
  • Create PRs per active branch instead of using the backport labels.
  • Use slack composite action.
  • Notify the robots team if something goes wrong with the GH actions.
  • Enable auto approval and auto-merge with Mergify [Need to configure the branch protections accordingly]

Why is it important?

A follow-up from #8211

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

$ GITHUB_TOKEN=$(gh auth token) \
  GITHUB_ACTOR=v1v \
  BRANCH_NAME=main updatecli apply \
    --config .ci/updatecli/updatecli-bump-vm-images.yml \
    --values .ci/updatecli/values.d/scm.yml

Produced v1v#7

Then I targeted a different branch

$ GITHUB_TOKEN=$(gh auth token) \
  GITHUB_ACTOR=v1v \
  BRANCH_NAME=main updatecli apply \
    --config .ci/updatecli/updatecli-bump-vm-images.yml \
    --values .ci/updatecli/values.d/scm.yml

Produced v1v#8

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@v1v v1v requested review from a team as code owners June 5, 2025 17:26
@v1v v1v requested review from kaanyalti and pchila June 5, 2025 17:26
@mergify mergify bot assigned v1v Jun 5, 2025
@v1v v1v requested a review from pkoutsovasilis June 10, 2025 06:26
Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so some context here, I did talked with @v1v yesterday about this condition author=github-actions[bot] and if it derives only from the github username and if that can be exploited. So @v1v investigated and it looks safe enough, so LGTM

@v1v v1v mentioned this pull request Jun 12, 2025
8 tasks
@v1v v1v merged commit aa2d900 into elastic:main Jun 12, 2025
9 checks passed
@v1v v1v added backport-active-all Automated backport with mergify to all the active branches and removed backport-skip labels Jun 15, 2025
@v1v
Copy link
Member Author

v1v commented Jun 15, 2025

@Mergifyio backport 8.18 8.19 9.0 8.17

@mergify
Copy link
Contributor

mergify bot commented Jun 15, 2025

mergify bot pushed a commit that referenced this pull request Jun 15, 2025
dliappis added a commit that referenced this pull request Jun 23, 2025
…ons (#8359) (#8509)

(cherry picked from commit aa2d900)

Co-authored-by: Victor Martinez <[email protected]>
Co-authored-by: Dimitrios Liappis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-all Automated backport with mergify to all the active branches skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants