Skip to content

Conversation

@v1v
Copy link
Member

@v1v v1v commented Jun 12, 2025

What does this PR do?

Add a branch name in the Slack error message.
Checkout the branch with the upatecli pipeline changes to fix this error

image

Why is it important?

This will help when configuration changes are different between branches.

However, this will require maintaining the updatecli pipeline in different branches too.

#8359 introduced the support for .buildkite/bk.integration-fips.pipeline.yml but #8035 was only backported to 8.19. Hence it failed for 9.0, 8.18 and 8.17.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

this will help when configuration changes are different between branches

this will require to maintain the updatecli pipeline in different branches too
@v1v v1v self-assigned this Jun 12, 2025
@v1v v1v requested a review from a team as a code owner June 12, 2025 11:48
@v1v v1v requested a review from a team as a code owner June 12, 2025 11:48
@v1v v1v requested a review from pkoutsovasilis June 12, 2025 11:48
@pkoutsovasilis
Copy link
Contributor

/test

@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @v1v

@v1v v1v merged commit 6ea85a6 into elastic:main Jun 13, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants