Skip to content

[CI] Mergify autoapprove configuration for ESS version pinning #8528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 16, 2025
Merged

[CI] Mergify autoapprove configuration for ESS version pinning #8528

merged 3 commits into from
Jun 16, 2025

Conversation

@pazone
Copy link
Contributor

@pazone pazone commented Jun 16, 2025 •
edited
Loading

What does this PR do?

A follow up for #8352

Creates autoapprove and automerge pull request rules that are triggered when:

  • the only pkg/testing/ess/create_deployment_csp_configuration.yaml is changed
  • PR author: github-actions[bot]
  • buildkite/elastic-agent passed
  • Head starts with updatecli_

Additional condition for automerge: The number of approvals is greater than or equal to 1

Why is it important?

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@pazone pazone added enhancement New feature or request skip-changelog backport-active-all Automated backport with mergify to all the active branches labels Jun 16, 2025
@mergify mergify bot assigned pazone Jun 16, 2025
@pazone pazone requested a review from v1v June 16, 2025 13:55
v1v
v1v reviewed Jun 16, 2025
View reviewed changes
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we can add the automation for rebase PRs if they not up-to-date and their CI failed? See #8470

@pazone
Copy link
Contributor Author

pazone commented Jun 16, 2025

Do you think we can add the automation for rebase PRs if they not up-to-date and their CI failed? See #8470

The suggestion is clear. Do I need to specify a schedule for the reabse rule?

pazone
pazone commented Jun 16, 2025
View reviewed changes
@pazone pazone requested a review from pkoutsovasilis June 16, 2025 14:17
@pazone pazone marked this pull request as ready for review June 16, 2025 14:18
@pazone pazone requested a review from a team as a code owner June 16, 2025 14:18
@pazone pazone requested a review from swiatekm June 16, 2025 14:18
v1v
v1v approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@v1v v1v left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, already reviewed together and tested using https://dashboard.mergify.com/workflow-automation?repository=elastic-agent&login=elastic. Thanks Pavel

I removed the backport labels, mergify does only honour the default branch.

@v1v v1v added backport-skip and removed backport-active-all Automated backport with mergify to all the active branches labels Jun 16, 2025
@pkoutsovasilis pkoutsovasilis mentioned this pull request Jun 16, 2025
Merged
8 tasks
@pazone
Copy link
Contributor Author

pazone commented Jun 16, 2025

@pkoutsovasilis

@pazone pazone merged commit 41a3964 into main Jun 16, 2025
11 checks passed
@pazone pazone deleted the ci_mergify_automerge_config branch June 16, 2025 15:37
@v1v v1v mentioned this pull request Jul 8, 2025
Merged
8 tasks
v1v added a commit that referenced this pull request Jul 9, 2025
@v1v
Revert [CI] Stable stack version override #8352 and #8528 (#8889)
fb8b883
mergify bot pushed a commit that referenced this pull request Jul 9, 2025
@v1v @mergify
Revert [CI] Stable stack version override #8352 and #8528 (#8889)
07c3550 
(cherry picked from commit fb8b883)

# Conflicts:
#	pkg/testing/ess/create_deployment_csp_configuration.yaml
@mergify mergify bot mentioned this pull request Jul 9, 2025
Merged
8 tasks
v1v pushed a commit that referenced this pull request Jul 14, 2025
@mergify
[9.1] (backport #8889) Revert [CI] Stable stack version override #8352 …
d5143a7 
…and #8528 (#8907)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@v1v v1v v1v approved these changes

@swiatekm swiatekm Awaiting requested review from swiatekm swiatekm is a code owner automatically assigned from elastic/elastic-agent-control-plane

+1 more reviewer

@pkoutsovasilis pkoutsovasilis pkoutsovasilis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pazone pazone

Labels

backport-skip enhancement New feature or request skip-changelog Team:Ingest-EngProd

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pazone @v1v @pkoutsovasilis