Skip to content

Fix arbitrary file write extracting an archive containing symbolic links #9660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

Fix arbitrary file write extracting an archive containing symbolic links #9660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions dev-tools/mage/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,14 @@ func untar(sourceFile, destinationDir string) error {
if err := os.MkdirAll(filepath.Dir(path), 0755); err != nil {
return err
}
// Check that creating a symlink at 'path' pointing to 'header.Linkname' is safe (stays in destinationDir)
safe, err := isSafeSymlink(path, header.Linkname, destinationDir)
if err != nil {
return fmt.Errorf("error evaluating symlink %s -> %s: %w", path, header.Linkname, err)
}
if !safe {
return fmt.Errorf("refusing to create unsafe symlink %s -> %s (outside extraction dir)", path, header.Linkname)
}
if err := os.Symlink(header.Linkname, path); err != nil {
return fmt.Errorf("error creating symlink %s pointing to %s: %w", path, header.Linkname, err)
}
Expand Down