-
Notifications
You must be signed in to change notification settings - Fork 188
Refactor to optimise for Windows service manager checkin #9672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
michalpristas
wants to merge
11
commits into
elastic:main
Choose a base branch
from
michalpristas:play/init-svc-start
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💛 Build succeeded, but was flaky
Failed CI StepsHistory
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-skip
bug
Something isn't working
skip-changelog
Team:Elastic-Agent-Control-Plane
Label for the Agent Control Plane team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is huge but it does just few things.
It does not use
elastic-agent-libs
for callingProcessWindowsControlEvents
.ProcessWindowsControlEvents
creates an objects that serves as an service instance and communicates with service manager. But having this in libs has an effect of runninginit
section of wholeelastic-agent-libs
dependency tree before registering with a service.It splits
agent/cmd
package into sub packages isolating each command. Service Manager communication is then moved outside tointernal/pkg/agent/agentservice
as described in first step. Having this split and service in a package deliberately named makes init section ofagentservice
being called sooner during initialization.In
agentservice
init service we addWaitGroup
when spinning upProcessWindowsControlEvents
goroutine. This blocks loading of subsequent packages and avoids possibility of starving ourselves of resources (when new goroutines are started later, subprocesses...). We cannot guarantee ordering of goroutines and that this one will be up in time. This is best effort of achieving that.It's essential to have a package named like this because of the way how init section loading is implemented (alphabetical sorting plays a significant role)
Result of this is that we not just moved communication a way sooner to init section (normally end of init due to big dependency tree)
But also moved it before proceeding with initialization of
This makes separation of otel into custom binary not critical for issues related to windows service manager communication timeouts.
Related #4971