Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This change simplifies the configuration by making the
fields.yml
file optional, as long as the config provides fields definitions — this is being checked in the command.A new
FieldMapping
struct that matches theField
struct has been added in config. If a path to a fields definitions file is provided, the generator uses the field definitions from that file. Otherwise, the field definitions are created directly from the config file.The
Value
field inside theField
struct has been changed fromstring
toany
. This eliminates the need for type conversion. Converting would be straightforward for integers and floats, but we can also have slices as values. Making theValue
field match the type of theValue
field from theConfig
struct seems like a more suitable approach.How I tested
Used
aws.ec2_metrics/schema-b
.configs.yml
Closes: #148