Skip to content

Conversation

@SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Aug 14, 2024

Relates to open-telemetry/opentelemetry-java-contrib#1414 in the upstream contrib repo, constant is duplicated and needs to be kept in sync until available in a new contrib release.

Update: using elastic.otel.java.span-stacktrace.min.duration as the upstream config is not yet stable and will require further discussion, so let's stick to elastic namespace for now.

@SylvainJuge SylvainJuge mentioned this pull request Aug 14, 2024
10 tasks
@SylvainJuge
Copy link
Member Author

Currently blocked on having the open-telemetry/opentelemetry-java-contrib#1414 reviewed and merged, as until it's merged the config option naming is not set in stone.

@SylvainJuge SylvainJuge changed the title align config with upstream contrib span stacktraces align config with upstream contrib Aug 22, 2024
@jackshirazi
Copy link
Contributor

and docs/configure.md

@SylvainJuge SylvainJuge changed the title span stacktraces align config with upstream contrib span stacktraces config (without aligning with upstream) Sep 2, 2024
@SylvainJuge SylvainJuge marked this pull request as ready for review September 2, 2024 13:16
@SylvainJuge SylvainJuge requested a review from a team September 2, 2024 13:16
@SylvainJuge SylvainJuge merged commit e3243bd into elastic:main Sep 2, 2024
@SylvainJuge SylvainJuge deleted the span-stacktrace-upstream-config branch September 2, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants