Skip to content

Conversation

@elastic-observability-automation
Copy link
Contributor

@elastic-observability-automation elastic-observability-automation bot commented Nov 14, 2024

@elastic/apm-agent-java, can you please check and merge this PR?


Upgrade the upstream agent version and related transitive dependencies

Update upstream OpenTelemetry agent version and related dependencies

ran shell command "gradle/update-upstream.sh v2.10.0 && echo \"Update successful\""

GitHub Action workflow link
Updatecli logo

Created automatically by Updatecli

Options:

Most of Updatecli configuration is done via its manifest(s).

  • If you close this pull request, Updatecli will automatically reopen it, the next time it runs.
  • If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.

Feel free to report any issues at github.com/updatecli/updatecli.
If you find this tool useful, do not hesitate to star our GitHub repository as a sign of appreciation, and/or to tell us directly on our chat!

@elastic-observability-automation elastic-observability-automation bot added the dependencies Pull requests that update a dependency file label Nov 14, 2024
@github-actions
Copy link

👋 @elastic-observability-automation[bot] Thanks a lot for your contribution!

It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it.

Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it.


@Test
void checkMinDurationRespected() {
void checkInferredSpansIgnored() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[for reviewer] this implicitly tests that the feature is working as expected, in particular that the filter configuration has been properly set and is working as expected.

@@ -1,41 +0,0 @@
/*
* Licensed to Elasticsearch B.V. under one or more contributor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[for reviewer] removed because now useless

@@ -1,301 +0,0 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[for reviewer] removed because it's unused and we'll re-implement it later if needed

@@ -1,56 +0,0 @@
/*
* Licensed to Elasticsearch B.V. under one or more contributor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[for reviewer] removed because now useless


// must match value in io.opentelemetry.contrib.stacktrace.StackTraceAutoConfig
private static final String STACKTRACE_OTEL_FILTER =
"otel.java.experimental.span-stacktrace.filter";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are again faulty config option names: due to containing a --character, it is impossible to provide those via environment variables. We should fix this in the upstream.

@elastic-observability-automation elastic-observability-automation bot force-pushed the updatecli_main_2370090022548352370298855724627f7945c7d64a355c6c7d1221ca3289fcc7 branch from ed94755 to 5b569f6 Compare November 21, 2024 06:02
@SylvainJuge SylvainJuge deleted the updatecli_main_2370090022548352370298855724627f7945c7d64a355c6c7d1221ca3289fcc7 branch November 21, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-java community dependencies Pull requests that update a dependency file triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants