-
Notifications
You must be signed in to change notification settings - Fork 23
Update upstream OpenTelemetry agent dependencies to 2.10.0 #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 @elastic-observability-automation[bot] Thanks a lot for your contribution! It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it. Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it. |
|
|
||
| @Test | ||
| void checkMinDurationRespected() { | ||
| void checkInferredSpansIgnored() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[for reviewer] this implicitly tests that the feature is working as expected, in particular that the filter configuration has been properly set and is working as expected.
| @@ -1,41 +0,0 @@ | |||
| /* | |||
| * Licensed to Elasticsearch B.V. under one or more contributor | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[for reviewer] removed because now useless
| @@ -1,301 +0,0 @@ | |||
| /* | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[for reviewer] removed because it's unused and we'll re-implement it later if needed
| @@ -1,56 +0,0 @@ | |||
| /* | |||
| * Licensed to Elasticsearch B.V. under one or more contributor | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[for reviewer] removed because now useless
common/src/test/java/co/elastic/otel/common/ChainingSpanProcessorAutoConfigurationTest.java
Outdated
Show resolved
Hide resolved
|
|
||
| // must match value in io.opentelemetry.contrib.stacktrace.StackTraceAutoConfig | ||
| private static final String STACKTRACE_OTEL_FILTER = | ||
| "otel.java.experimental.span-stacktrace.filter"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are again faulty config option names: due to containing a --character, it is impossible to provide those via environment variables. We should fix this in the upstream.
ed94755 to
5b569f6
Compare
@elastic/apm-agent-java, can you please check and merge this PR?
Upgrade the upstream agent version and related transitive dependencies
Update upstream OpenTelemetry agent version and related dependencies
ran shell command "gradle/update-upstream.sh v2.10.0 && echo \"Update successful\""
Created automatically by Updatecli
Options:
Most of Updatecli configuration is done via its manifest(s).
Feel free to report any issues at github.com/updatecli/updatecli.
If you find this tool useful, do not hesitate to star our GitHub repository as a sign of appreciation, and/or to tell us directly on our chat!