-
Notifications
You must be signed in to change notification settings - Fork 20
switch to 2.18.1, and switch openai to upstream #763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
c4e5fcf
9afd6d4
bdbcb20
0295ec6
3c283fe
c8e9059
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -85,9 +85,11 @@ | |
import java.util.function.Consumer; | ||
import java.util.stream.Collectors; | ||
import org.junit.jupiter.api.BeforeEach; | ||
import org.junit.jupiter.api.Disabled; | ||
import org.junit.jupiter.api.Test; | ||
import org.junit.jupiter.api.extension.RegisterExtension; | ||
|
||
@Disabled | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If I understand correctly disabling those tests is required because now the upstream instrumentation is used. Do we already have an issue that describes the deprecation and removal steps ? Aligning the removal with the update to 3.x upstream seems a good option as it already forces to do a new major. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No issue opened yet, I will open when this is merged |
||
class ChatTest { | ||
|
||
@RegisterExtension | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the difference between those two variables ? are there two instrumentations or at least two config options in upstream ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the upstream one uses OTEL_INSTRUMENTATION_OPENAI, while our implementation uses OTEL_INSTRUMENTATION_OPENAI_CLIENT. If the upstream one had used the same var, it wouldn't have been a breaking change and we could have just removed our implementation