Skip to content

Hook up sampler #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 30, 2025
Merged

Hook up sampler #810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2fe3281
add sampler
jackshirazi Sep 29, 2025
975af0f
add sampler
jackshirazi Sep 29, 2025
f0d9180
fix order
jackshirazi Sep 29, 2025
eca5819
fix typos
jackshirazi Sep 29, 2025
1fdd805
another typo
jackshirazi Sep 29, 2025
d65aede
spotless
jackshirazi Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions custom/src/main/java/co/elastic/otel/ElasticAutoConfigurationCustomizerProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
*/
package co.elastic.otel;

import co.elastic.otel.compositesampling.DynamicCompositeParentBasedTraceIdRatioBasedSampler;
import co.elastic.otel.dynamicconfig.BlockableLogRecordExporter;
import co.elastic.otel.dynamicconfig.BlockableMetricExporter;
import co.elastic.otel.dynamicconfig.BlockableSpanExporter;
Expand Down Expand Up @@ -91,6 +92,7 @@ public void customize(AutoConfigurationCustomizer autoConfiguration) {
(providerBuilder, properties) -> {
CentralConfig.init(providerBuilder, properties);
AgentLog.addSpanLoggingIfRequired(providerBuilder, properties);
providerBuilder.setSampler(DynamicCompositeParentBasedTraceIdRatioBasedSampler.INSTANCE);
return providerBuilder;
});
}
Expand Down
15 changes: 15 additions & 0 deletions custom/src/main/java/co/elastic/otel/dynamicconfig/CentralConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
*/
package co.elastic.otel.dynamicconfig;

import co.elastic.otel.compositesampling.DynamicCompositeParentBasedTraceIdRatioBasedSampler;
import co.elastic.otel.dynamicconfig.internal.OpampManager;
import co.elastic.otel.logging.AgentLog;
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
Expand Down Expand Up @@ -128,6 +129,7 @@ public static class Configs {
new DeactivateAllInstrumentations(),
new DeactivateInstrumentations(),
new LoggingLevel(),
new SamplingRate(),
new PollingInterval())
.collect(Collectors.toMap(ConfigOption::getConfigName, option -> option));
}
Expand Down Expand Up @@ -299,6 +301,19 @@ void update(String configurationValue, OpampManager opampManager)
}
}

public static final class SamplingRate extends ConfigOption {
SamplingRate() {
super("sampling_rate", "1.0");
}

@Override
void update(String configurationValue, OpampManager opampManager)
throws IllegalArgumentException {
DynamicCompositeParentBasedTraceIdRatioBasedSampler.setRatio(
Double.parseDouble(configurationValue));
}
}

public static final class PollingInterval extends ConfigOption {
PollingInterval() {
super("opamp_polling_interval", "30s");
Expand Down
Loading