add support for elastic.otel.opamp.headers config #848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LikeTheSalad
previously approved these changes
Oct 21, 2025
SylvainJuge
commented
Oct 21, 2025
| return serviceName; | ||
| } | ||
| Map<String, String> resourceMap = properties.getMap("otel.resource.attributes"); | ||
| if (resourceMap != null) { |
Member
Author
There was a problem hiding this comment.
for review: here we can simplify a bit because an empty map is returned, we never get a null collection (now covered by tests).
LikeTheSalad
previously approved these changes
Oct 21, 2025
LikeTheSalad
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #833
Adds support for:
ELASTIC_OTEL_OPAMP_HEADERSconfiguration optionelastic.otel.opamp.headersjava system propertyBonus: