Skip to content

Conversation

jomi-se
Copy link

@jomi-se jomi-se commented Jun 17, 2025

Fix for #846

I dunno if you guys have some other stuff to add to this

@jomi-se jomi-se requested a review from a team as a code owner June 17, 2025 13:43
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
1e95158

Please, read and sign the above mentioned agreement if you want to contribute to this project

@david-luna
Copy link
Member

Hi @jomi-se

thanks for your contribution to fix the issue :)

if you sing the CLA I would be able to run the CI and merge the fix for the next release.

Cheers

@trentm
Copy link
Member

trentm commented Jun 18, 2025

FYI: I have some questions on how to repro the issue on #846

@trentm
Copy link
Member

trentm commented Jun 18, 2025

Do you possibly have this pnpm setting set to false? https://pnpm.io/settings#peer-dependency-settings
What version of pnpm are you using?


Whatever the answer, I think I agree that @opentelemetry/api should be in "dependencies" rather than just in "peerDependencies". I wonder how this has no bitten the many @opentelemetry/* packages that do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants