elastic-opentelemetry-instrumentation-openai: assert exported schema version #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I guess #23 will get merged first, so this diff will end up being just the one commit here and be a lot smaller. |
trentm
approved these changes
Nov 14, 2024
Member
Author
Yeah, I'm doing PRs on top of others to avoid conflicts and do more work in advance as possible before I get a reviewer up :) |
xrmx
force-pushed
the
assert-exported-schema
branch
from
1dfee4c to
7ff4131
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Add proper test instead of asserting against mocks.
Related issues