Skip to content

Conversation

SrdjanLL
Copy link
Contributor

What does this pull request do?

  • Use gen_ai.output.type instead of deprecated gen_ai.openai.request.response_format attribute.
  • Use json instead of json_schema|json_object for gen_ai.output.type attribute value, as the enum options for the new attribute changed to be more generic (see here)
  • Update tests to reflect the changes above.

Related issues

Closes #52

@SrdjanLL SrdjanLL requested review from estolfo and xrmx April 15, 2025 14:26
Copy link
Member

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, while you are at it could you please bump the schema url in src/opentelemetry/instrumentation/openai/__init__.py to 1.31? Thanks

@SrdjanLL SrdjanLL merged commit 4971007 into elastic:main Apr 16, 2025
14 checks passed
@SrdjanLL SrdjanLL deleted the semconv-1.31.0 branch April 16, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

openai: 1.31.0 semconv changes

3 participants