Skip to content

distro: set OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE to DELTA #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2024
Merged

distro: set OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE to DELTA #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/elasticotel/distro/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
from opentelemetry.sdk.environment_variables import (
OTEL_METRICS_EXEMPLAR_FILTER,
OTEL_EXPERIMENTAL_RESOURCE_DETECTORS,
OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE,
OTEL_EXPORTER_OTLP_PROTOCOL,
_OTEL_PYTHON_LOGGING_AUTO_INSTRUMENTATION_ENABLED,
)
Expand Down Expand Up @@ -141,3 +142,5 @@ def _configure(self, **kwargs):
os.environ.setdefault(OTEL_EXPERIMENTAL_RESOURCE_DETECTORS, "process_runtime,os,otel,telemetry_distro")
# disable exemplars by default for now
os.environ.setdefault(OTEL_METRICS_EXEMPLAR_FILTER, "always_off")
# preference to use DELTA temporality as we can handle only this kind of Histograms
os.environ.setdefault(OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE, "DELTA")
2 changes: 2 additions & 0 deletions tests/distro/test_distro.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
from opentelemetry.sdk.environment_variables import (
OTEL_METRICS_EXEMPLAR_FILTER,
OTEL_EXPERIMENTAL_RESOURCE_DETECTORS,
OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE,
OTEL_EXPORTER_OTLP_PROTOCOL,
)

Expand All @@ -44,6 +45,7 @@ def test_default_configuration(self):
"process_runtime,os,otel,telemetry_distro", os.environ.get(OTEL_EXPERIMENTAL_RESOURCE_DETECTORS)
)
self.assertEqual("always_off", os.environ.get(OTEL_METRICS_EXEMPLAR_FILTER))
self.assertEqual("DELTA", os.environ.get(OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE))

@mock.patch.dict("os.environ", {}, clear=True)
def test_load_instrumentor_call_with_default_kwargs_for_SystemMetricsInstrumentor(self):
Expand Down